Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate caching for NVD checks #7

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Use separate caching for NVD checks #7

merged 1 commit into from
Jun 11, 2024

Conversation

joodie
Copy link
Contributor

@joodie joodie commented Jun 11, 2024

The NVD database should be cached independently of the dependencies of the project. This stores the NVD database under a key based on the data of running the check. If that key isn't found, it will fetch whatever is the latest NVD database key in the cache.

@joodie joodie force-pushed the cache-ndv-database branch 3 times, most recently from 06d0a3a to e1ba41d Compare June 11, 2024 14:48
The NVD database should be cached independently of the dependencies of
the project. This stores the NVD database under a key based on the
data of running the check. If that key isn't found, it will fetch
whatever is the latest NVD database key in the cache.

Note that if no cache is found in the current branch, it will be
looked up in the main branch.
@joodie joodie force-pushed the cache-ndv-database branch from e1ba41d to d3c582a Compare June 11, 2024 15:04
@joodie joodie requested a review from remvee June 11, 2024 15:05
@joodie joodie marked this pull request as ready for review June 11, 2024 15:05
Copy link
Contributor

@remvee remvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joodie joodie merged commit 14b1d5b into main Jun 11, 2024
4 checks passed
@joodie joodie deleted the cache-ndv-database branch June 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants