Added message to people without permissions #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… were deleted when logging out
YotaYota
requested changes
Nov 25, 2024
|
YotaYota
reviewed
Nov 26, 2024
| setInfoMessage("You're logged in."); | ||
| window.location.replace("/"); | ||
| } else { | ||
| putPermissions(data); |
There was a problem hiding this comment.
should we putPermissions here, when data has no length? Or is it setting []?
There was a problem hiding this comment.
It's setting []. I also thought about not setting it, but I think it's better we save it empty so we know we don't have to request it anymore. If you have a different logic on it, let me know.
YotaYota
approved these changes
Nov 26, 2024
|
LGTM 👍 just a rebase I suppose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added message to people without permissions and made sure permission were deleted when logging out