SUP-180: local footer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookmish
force-pushed
the
SUP-180--local-footer
branch
from
1389f6c to
ee151ab
Compare
pookmish
approved these changes
Apr 18, 2024
src/styles/fonts.tsx
Outdated
|
|
||
| export const sourceSans3 = Source_Sans_3({ | ||
| export const sourceSans3 = Montserrat({ |
There was a problem hiding this comment.
If you change the font, you should change the variable name here and in the layout.tsx where it is used.
I'll fix it though.
There was a problem hiding this comment.
Oh right, good point.
| width?: number | ||
| } | ||
|
|
||
| const PressFooterLogoLg = ({height = 89, width = 579, ...props}: Props) => { |
There was a problem hiding this comment.
You should add {...props} to the svg attributes.
There was a problem hiding this comment.
Ok. Thanks for the feedback!
| width?: number | ||
| } | ||
|
|
||
| const PressFooterLogoXs = ({height = 91, width = 426, ...props}: Props) => { |
There was a problem hiding this comment.
You should add {...props} to the svg attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
-- Changed the bg color
-- Changed the link colors
-- Reordered content
-- Spacing below the
h2to match design-- Spacing on the columns between the lines and the center column of links.
-- Change the m1 font sizing to the type-0 to type-10. This is more up to date way to have the responsive font sizing.
Review By (Date)
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
drush cr ; drush ciSite Configuration Sync
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
- SUP-180
Resources