Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ghost button hover/focus state and finetune button sizes #81

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Oct 28, 2020

READY FOR REVIEW

Summary

  • Update ghost button hover/focus styles
  • Finetune medium and large button style mobile padding/font size

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Go to https://deploy-preview-81--adapt-giving.netlify.app/why-give/
  2. Scroll to the first poster "7 reason why giving matters"
  3. hover over the button "Why giving matters" and check that the border expands inward to 3 px thick and there is an underline on the text.
  4. Click into the button link (CTA link) component and play with the 3 button size options - small (default), medium and large. Check that they work ok.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yvonnetangsu yvonnetangsu merged commit 191f08f into main Oct 28, 2020
@yvonnetangsu yvonnetangsu deleted the ADAPT-1135-ghost-button-hocus branch October 28, 2020 16:02
yvonnetangsu added a commit that referenced this pull request Oct 28, 2020
* main:
  Update netlify.toml
  Update ghost button hover/focus state and finetune button sizes (#81)
  ADAPT-783 Close mega menu dropdown when clicking outside (#76)
yvonnetangsu added a commit that referenced this pull request Oct 28, 2020
* main:
  Update netlify.toml
  Update ghost button hover/focus state and finetune button sizes (#81)
  ADAPT-783 Close mega menu dropdown when clicking outside (#76)
yvonnetangsu added a commit that referenced this pull request Oct 28, 2020
* main:
  Update netlify.toml
  Update netlify.toml
  Update ghost button hover/focus state and finetune button sizes (#81)
  ADAPT-783 Close mega menu dropdown when clicking outside (#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants