Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup - add headline underline back in when mega menu card is hovered/focused #63

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Oct 20, 2020

READY FOR REVIEW

Summary

  • Fix incorrrect scss nesting causing mega menu card. Headline should have underline when card is hovered/focused.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Go to https://5f8f5aed179808000725e082--adapt-giving.netlify.app/
  2. Hover on "About" in the mega menu
  3. Hover over the card in the mega menu dropdown and see that the card headline gets an underline.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@yvonnetangsu

This comment has been minimized.

* main:
  disable a117 plugin (#64)
  Adapt 767  content menu colors (#60)
@katrialesser katrialesser merged commit c7f1441 into main Oct 20, 2020
@katrialesser katrialesser deleted the fixup-menu-card-underline branch October 20, 2020 22:02
yvonnetangsu added a commit that referenced this pull request Oct 21, 2020
* main:
  fixup mega menu card headline incorrect nesting causing underline to disappear on hover/focus (#63)
  disable a117 plugin (#64)
  Adapt 767  content menu colors (#60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants