Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update endowed positions dataset #448

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

wmui51
Copy link
Collaborator

@wmui51 wmui51 commented Oct 22, 2024

READY FOR REVIEW

Summary

  • New endowed positions dataset update. Client would like to go live on Thursday, Oct 24.

Review By Oct 23

  • Please push to Dev for client review and push to Prod on Thursday.

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@wmui51
Copy link
Collaborator Author

wmui51 commented Oct 22, 2024

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG merging into dev @forrestglick

@yvonnetangsu yvonnetangsu merged commit 7a8864c into dev Oct 22, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feat/endowed-positions-102424 branch October 22, 2024 20:28
@forrestglick
Copy link
Collaborator

Thanks @yvonnetangsu! You are so quick. Appreciate it :) I'll send to the client for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants