ADAPT-581: Clean up cards #44
Conversation
… card view; improve image display logic for stories
…formImage utility
* plugins: fixup! nope. fixup! try variables... fixup! settings fixup! settings fixup! swap out canonical url plugin. fixup! syntax. Added canonical url plugin. Added robots.txt plugins. Added xml sitemap plugin. Env vars set correct.
…ull story title and intro
* master: Plugins and robots. (#38)
* master: Plugins and robots. (#38)
…card font sizes/line-height
…atured-stories * ADAPT-795-content-font-size-and-misc: Fixup fixup More font size adjustments Caption font size finetune Add mixins ood-big-paragraph and ood-card-text; finetune content and card font sizes/line-height Bump up content font size per Kerri's request # Conflicts: # src/components/page-types/oodStory.js
* master: Netlify Dev Command (#41)
… quoteText and quoteSource richtext
…-cards * ADAPT-733-quote-card-fields: Use sass loop for before element colors More quote style refinement cleanup styles Add font size option for Quote Card body text Combines all the bio stuff into 1 single field quoteSource; make both quoteText and quoteSource richtext
| @@ -3,28 +3,32 @@ import { Link } from "gatsby" | |||
| import SbEditable from 'storyblok-react' | |||
|
|
|||
| const OodTileCard = (props) => { | |||
| const Heading = props.blok.headingLevel; | |||
There was a problem hiding this comment.
@yvonnetangsu This is showing up as undefined and causing a render error on line 22.
There was a problem hiding this comment.
@sherakama Try my test page:
http://app.storyblok.com/#!/me/spaces/78141/stories/0/0/20109634
Sometimes that happens when new schema is added or changed. Also try deleting the whole section with the tile cards in your test page, and re-add using the whole section as a preset (Example masonry I want to card section) - I updated the section preset with the latest version.
There was a problem hiding this comment.
@sherakama I went into your test story page and jiggle things a bit. The page should load now.
There was a problem hiding this comment.
@sherakama Fixed the homepage too - should be ok now.
There was a problem hiding this comment.
hmmm. Were going to have to practice handling these kinds of content type upgrades. If we do change the scheme of existing content how does storyblok propagate the changes? Things for us to learn.
There was a problem hiding this comment.
Still getting and error on a page.
9:35:45 PM: failed Building static HTML for pages - 7.305s
9:35:45 PM: error Building static HTML failed for path "/test-items/yvonne/yvonne-test-landing-page/"
There was a problem hiding this comment.
I might not have published my changes so I just hit published. Let me see if I can build now 🤔
There was a problem hiding this comment.
Great! Glad it worked. Sorry about that.
There was a problem hiding this comment.
@sherakama I think I know what I need to do. I'm going to add a Heading component as a partial, and it will return a h3 to the tag when props.blok.headingLevel isn't specified. That way it wouldn't return an error when components hasn't been updated with the new option. Usually when adding schema it won't break existing pages, but in this case, the variable is in the HTML tag itself 😬
Thanks for merging - I probably still got some work left to do but I won't touch things tonight. Will open another PR tomorrow after the demo 😂 |
NOT READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)Resources