DS-748 | @ericbakenhus | Check for empty array before outputing menu #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbakenhus
commented
Jun 3, 2024
Comment on lines
-43
to
46
| {props.blok.relatedMenuLinks && ( | ||
| {!!props.blok.relatedMenuLinks?.length && ( | ||
| <div className={`ood-content-nav__menu-group`}> | ||
| {props.blok.relatedMenuTitle && ( | ||
| <Heading level={'h2'} classes={`ood-content-nav__title`}> |
There was a problem hiding this comment.
Don't output anything if there are no related menu links.
Merged
wmui51
pushed a commit
that referenced
this pull request
Jun 12, 2024
…426) * DS-748: Check for empty array * DS-748: Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
ul; switches to checking that the array exists and is not emptyReview By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People