-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set HSTS max-age to 15768000 #402
Conversation
@jbickar What are your thoughts on bumping this up to 1 year and submitting to https://hstspreload.org/? |
I don't have a problem with it philosophically. I don't know the application well enough to know if that's a risk; my hunch says it's not. https://hstspreload.org/ suggests ramping up the |
I would say since you're already using HSTS and you haven't had any user complaints, it doesn't seem risky. |
It looks like we've been using it on all sites since 2020, so preloading and a long max-age seems good by me. |
@@ -14,7 +14,7 @@ | |||
Content-Security-Policy = "form-action https:" | |||
X-Content-Type-Options = "nosniff" | |||
Referrer-Policy = "origin-when-cross-origin" | |||
Strict-Transport-Security = "max-age=2592000" | |||
Strict-Transport-Security = "max-age=31536000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
31 meelyon
Moving forward with 1 year. Thanks @jbickar |
That is some ... A+ work. |
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test