Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT-724- mega menu active link style and a bunch of misc things #26

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Sep 19, 2020

…tons on areas to support page; add logic for rendering person info for quote cards; add pseudo element decorators; make scroll bar always appear in browser

READY FOR REVIEW/NOT READY

  • (Edit the above to reflect status)

Summary

  • Add active page style for top level menu links (only visible using build and not develop mode)
  • Add focus style for filter buttons on areas to support page;
  • Add logic for rendering person info for quote cards;
  • Add pseudo element decorators;
  • Make scroll bar always appear in browser

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

…tons on areas to support page; add logic for rendering person info for quote cards; add pseudo element decorators; make scroll bar always appear in browser
@yvonnetangsu yvonnetangsu merged commit e0d0ddd into master Sep 19, 2020
@yvonnetangsu yvonnetangsu deleted the ADAPT-724-mega-menu-active-styles branch September 19, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant