Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/adapt 3200 campaign page visual updates #226

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Release/adapt 3200 campaign page visual updates #226

merged 5 commits into from
Aug 20, 2021

Conversation

mattanglin
Copy link
Contributor

@mattanglin mattanglin commented Aug 20, 2021 •
edited
Loading

@mattanglin mattanglin requested a review from sherakama August 20, 2021 22:17
@mattanglin
Copy link
Contributor Author

@sherakama Just realized that we'll need to revert the dev specific changes for deploying to production. We might wanna try and get #221 reviewed and merged into dev so we can tag it into this deploy. Otherwise I can just revert the dev related changes. Let me know!

@sherakama
Copy link
Member

sherakama commented Aug 20, 2021 •
edited
Loading

@mattanglin there is still work/thought to do on #22. Create a new branch for this PR and rebase this PR without the dev commits to go into main. This is not ideal I know but for now it is what it is.

mattanglin and others added 5 commits August 20, 2021 16:05
@mattanglin
Conditionally render oodCampaignHeader homelink based on blok field (#…
c991df8 
…216)
@mattanglin
ADAPT-3203: Campaign hero serif variant (#222)
653a1ea 
ADAPT-3203: Campaign hero serif variant (#222)
@rebeccahongsf @mattanglin
ADAPT-3172: Update Node version to 16 from 15 (#224)
4b82441 
ADAPT-3172: Update Node version to 16 from 15 (#224)
@mattanglin @sherakama
ADAPT-3204 ADAPT-3205 | @mattanglin | noindex page option (#225)
b689112 
* Allow pages to be removed from search indexing and sitemap

* Omit noindex entites from algolia indexing

Co-authored-by: Sherakama <[email protected]>
@mattanglin @sherakama
ADAPT-3201 | @mattanglin | campaign header logo (#223)
c1fbad9 
* Optionally render logo image in campaign header when set

* Refactor custom logo image out of lockup and into cmapaign header

* Cleanup

Co-authored-by: Sherakama <[email protected]>
@mattanglin mattanglin force-pushed the release/ADAPT-3200_campaign-page-visual-updates branch from a4c7933 to c1fbad9 Compare August 20, 2021 23:07
@mattanglin
Copy link
Contributor Author

@mattanglin there is still work/thought to do on #22. Create a new branch for this PR and rebase this PR without the dev commits to go into main. This is not ideal I know but for now it is what it is.

@sherakama Rebased to remove the dev changes ✅

sherakama
sherakama approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. GTG.

@sherakama
Copy link
Member

Thanks @mattanglin

@mattanglin mattanglin merged commit 275c6bf into main Aug 20, 2021
@mattanglin mattanglin deleted the release/ADAPT-3200_campaign-page-visual-updates branch August 20, 2021 23:35
@yvonnetangsu
Copy link
Member

@sherakama @mattanglin This campaign page on live is rendering 2 lockups at the moment:
https://giving.stanford.edu/sykes-match/

yvonnetangsu
yvonnetangsu reviewed Aug 21, 2021
View reviewed changes
src/components/identity/oodCampaignHeader.js
</div>
) : (
<CreateBloks blokSection={props.blok.lockup} />
)}
<CreateBloks blokSection={props.blok.lockup} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to delete this line 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu left review comments

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattanglin @sherakama @yvonnetangsu @rebeccahongsf