Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT-2892 Resolve button transition flash #208

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

rebeccahongsf
Copy link
Contributor

READY FOR REVIEW

Summary

  • Create decorator class to resolve button transition flash for gradients.

Review By (Date)

  • June 25

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Run your local and checkout buttons at /test-items/rebecca/button-color-test

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG - thank you! 😄

@yvonnetangsu yvonnetangsu merged commit ea2ad6f into main Jun 24, 2021
@yvonnetangsu yvonnetangsu deleted the ADAPT-2892--btn-transition branch June 24, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants