Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT-779: Added hash navigation to Support page. #179

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Conversation

nplowman
Copy link

@nplowman nplowman commented Apr 5, 2021

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • Adds hashes to URL when selecting filters on /areas-to-support/. (This is to allow for better tracking in GTM).

Review By (Date)

  • Next 1-3 days.

Criticality

  • 5/10. Page is already functioning properly - this just allows for better tracking in GTM.

Review Tasks

Setup tasks and/or behavior to test

  1. Go to /areas-to-support on the preview build.
  2. Try clicking filter buttons, notice that the hash in the URL updates.
  3. Refresh page while having hash in URL. Validate that filters are set as expected on page load.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Associated Issues and/or People

@nplowman nplowman requested a review from sherakama April 5, 2021 17:07
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me with the one small change to the import statements.

@yvonnetangsu please have a review.

@yvonnetangsu
Copy link
Member

This looks fine to me with the one small change to the import statements.

@yvonnetangsu please have a review.

@sherakama @nplowman This is a fast and clever solution that would allow for GA tracking. I do wonder about the UX side of things - the scroll to position, and also the use of back button doesn't seem to trigger the different filter. I think perhaps we could have the client test it and see if they are ok with the UX (but let them know that it might take more time if they want a less "hacky" solution)?

@nplowman
Copy link
Author

nplowman commented Apr 8, 2021

@yvonnetangsu @sherakama PR has been updated with support for back button navigation.

@sherakama sherakama merged commit 6b0619d into main Apr 8, 2021
@sherakama sherakama deleted the ADAPT-779 branch April 8, 2021 20:42
@sherakama
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants