Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the content-dependent top-level CSS selector to fix the styling issue on the Service Catalog page #35

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

cdchangr
Copy link
Contributor

@cdchangr cdchangr commented Nov 9, 2024

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • The style for Service Catalog cards is messed up. The core service categories are not legible, not accessible and the client categories do not look clickable. This is caused by the missing top-level selector .section-service-catalog (which is content-dependent). Removing this selector restored the correct styling for the cards on the Service Catalog page.

Before

2024-11-08_16-30-40

After

2024-11-08_16-32-18

Review By (Date)

  • ASAP

Criticality

  • 10

Urgency

  • High

cdchangr and others added 2 commits November 9, 2024 00:20
RHW-66: Remove body class section-service-catalog to fix the Service Catalog page's styling issue
@buttonwillowsix buttonwillowsix merged commit 58b438c into SU-SWS:main Nov 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants