Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-5738 | @jdwjdwjdw | Update global footer for A11y #910

Merged
merged 3 commits into from
May 31, 2023

Conversation

jdwjdwjdw
Copy link

@jdwjdwjdw jdwjdwjdw commented May 17, 2023

READY FOR REVIEW

Summary

  • Global footer a11y updates. I am currently blocked in terms of being able to test these changes on my local, so additional work / changes will probably be needed. Please keep me updated on any issues that come up as you review.
  • D8CORE-2730: A11y: in the global footer add "Link is external" for AT to logo
  • D8CORE-5738: A11y | Decanter Global Footer: Links have different text and go to the same place
  • D8CORE-5798: A11y: in the global footer the "Link is external" needs spacing
  • D8CORE-6654: Update links in Global Footer
  • I also added a space before the (link is external) in the brand bar.

Needed By (Date)

  • When convenient

Urgency

  • Normal

Steps to Test

  1. Checkout branch
  2. Review and inspect the global footer on a site
  3. D8CORE-2730: confirm that link is external text has been added to the Logo
  4. D8CORE-5738: confirm that an aria-describedby and id has been added to connect the two links that go to the same place (The Stanford logo, and the Stanford Home link, and that WAVE no longer flags it as a redundant link
  5. D8CORE-5798: confirm that the link is external span includes a space at the beginning. I'm not sure if just adding a space is fine, or if we need to add   - I'm unable to test this work out currently, so let me know if that span is not showing a space

Associated Issues and/or People

  • D8CORE-2730: A11y: in the global footer add "Link is external" for AT to logo
  • D8CORE-5738: A11y | Decanter Global Footer: Links have different text and go to the same place
  • D8CORE-5798: A11y: in the global footer the "Link is external" needs spacing

Copy link
Contributor

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be merged into v6

@jdwjdwjdw jdwjdwjdw changed the base branch from master to v6 May 23, 2023 17:12
@jdwjdwjdw jdwjdwjdw changed the base branch from v6 to master May 23, 2023 17:13
@jdwjdwjdw jdwjdwjdw closed this May 23, 2023
@jdwjdwjdw jdwjdwjdw deleted the D8CORE-2730--global-footer-a11y branch May 23, 2023 17:42
@jdwjdwjdw jdwjdwjdw restored the D8CORE-2730--global-footer-a11y branch May 24, 2023 18:13
@jdwjdwjdw jdwjdwjdw reopened this May 24, 2023
@jdwjdwjdw
Copy link
Author

This would need to be merged into v6

Per our slack discussion, it looks like this turned out to be the correct branch, not v6, which we closed. This should be good to re-review based on that.

Copy link
Contributor

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdwjdwjdw jdwjdwjdw added the patch Releases a patch tag label May 31, 2023
@jdwjdwjdw jdwjdwjdw merged commit dc5ff62 into master May 31, 2023
@jdwjdwjdw jdwjdwjdw deleted the D8CORE-2730--global-footer-a11y branch May 31, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases a patch tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants