Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-2539: Add stretched-link and writing-mode utilities to v7 #843

Merged
merged 1 commit into from
Aug 4, 2021
Merged

ADAPT-2539: Add stretched-link and writing-mode utilities to v7 #843

merged 1 commit into from
Aug 4, 2021

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Jul 30, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Add stretched-link and writing-mode utilities to v7

Needed By (Date)

  • 08/06

Urgency

  • low

Steps to Test

  1. Pull this PR
  2. Follow dev README.md instructions to setup local dev.
  3. Copy and paste the following into your test.html
<!DOCTYPE html>
<html lang="en" dir="ltr" class="su-smooth-scroll">
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Decanter Preview Environment</title>
  </head>

  <body class="su-debug-screens">
    <!-- MAIN DEVELOPMENT AREA -->
    <a href="#top" class="su-skiplink">Skip to main content</a>
    <div class="su-bg-digital-red su-pt-5 su-pb-1">
      <div class="su-cc">
        <a
          class="su-logo su-text-white hocus:su-text-white su-text-20"
          href="https://stanford.edu"
          >Stanford University</a
        >
      </div>
    </div>
    <main id="top" class="su-p-5">
      <div
        class="
          card
          su-block
          su-max-w-600
          su-basefont-23
          su-leading-display
          su-bg-white
          su-text-black
          su-border
          su-border-solid
          su-border-black-10
          su-shadow
          su-relative
        "
      >
        <div class="su-aspect-w-2 su-aspect-h-1" aria-hidden="true">
          <img
            src="https://placekitten.com/600/300"
            alt=""
            class="su-object-cover"
          />
        </div>
        <div
          class="
            su-flex su-flex-col
            card-body
            su-items-start su-rs-px-2 su-rs-pt-2 su-rs-pb-4
          "
        >
          <span
            class="
              su-type-0 su-mb-0 su-leading-display su-font-bold su-uppercase
            "
          >
            Super headline
          </span>
          <h3
            class="
              su-leading-display su-font-sans su-font-bold su-type-2 su-mb-03em
            "
          >
            Headline
          </h3>
          <p class="su-card-paragraph">
            Fusce convallis metus id felis luctus adipiscing. Vestibulum
            suscipit nulla quis orci. Phasellus a est.
          </p>
          <a
            class="
              su-cta-button
              su-font-regular
              su-leading-display
              su-block
              su-w-fit
              su-no-underline
              hover:su-underline
              focus:su-underline
              su-group
              su-transition-colors
              su-px-26
              su-pt-10
              su-pb-11
              su-text-16
              md:su-text-20
              su-bg-white
              hocus:su-bg-white
              su-text-digital-red
              hocus:su-text-black
              su-border-2 su-border-digital-red su-border-solid
              hover:su-border-black
              focus:su-border-black
              su-mt-16 su-stretched-link
            "
            href="https://decanter.stanford.edu"
          >
            Learn more
            <span class="su-sr-only">about Decanter</span>
          </a>
          <div
            class="
              su-absolute
              su-top-0
              su-left-0
              su-rs-ml-2
              su-pr-8
              su-pl-9
              su-pb-2
              su-pt-12
              su-bg-digital-red-light
              su-text-white
              su-font-semibold
              su-leading-none
              su-text-vertical-lr
              su-transform
              su-rotate-180
              su-shadow-sm
            "
          >
            New
            <span class="su-sr-only">Members</span>
          </div>
        </div>
      </div>
    </main>
    <!-- END DEVELOPMENT AREA -->
  </body>
</html>

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

See Also

yvonnetangsu
yvonnetangsu approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this - GTG! 😄 🙏🏼

@yvonnetangsu yvonnetangsu added the alpha Releases an alpha tag label Aug 4, 2021
@yvonnetangsu
Copy link
Member

@rebeccahongsf @sherakama I added an alpha tag to this one

@yvonnetangsu
Copy link
Member

Hmm actually, maybe I should use the "beta" tag instead @sherakama ? PR is good to go. Please feel free to re-tag and merge after 🙏🏼

@yvonnetangsu yvonnetangsu removed the alpha Releases an alpha tag label Aug 4, 2021
@sherakama sherakama added the beta Releases a beta tag label Aug 4, 2021
sherakama
sherakama approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG by me.

@sherakama sherakama changed the title ADAPT-2539 Add stretched-link and writing-mode utilities to v7 ADAPT-2539: Add stretched-link and writing-mode utilities to v7 Aug 4, 2021
@sherakama sherakama merged commit d09c49b into v7 Aug 4, 2021
@sherakama sherakama deleted the ADAPT-2539--utilities branch August 4, 2021 21:09
@yvonnetangsu
Copy link
Member

@rebeccahongsf This one has been merged so you could move that ticket to done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
beta Releases a beta tag size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebeccahongsf @yvonnetangsu @sherakama