Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-1771: Linting Configuration #821

Merged
merged 3 commits into from
May 7, 2021
Merged

ADAPT-1771: Linting Configuration #821

merged 3 commits into from
May 7, 2021

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented May 7, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Runs linters

Needed By (Date)

  • Whenever

Urgency

  • 0

Steps to Test

  1. Review code
  2. Review build preview
  3. Check out this branch on your local
  4. Update your npm modules (nvm use && npm install)
  5. Run the linter (npm run lint) and validate no linting errors.
  6. Code climate won't run on this yet as it only runs on PRs to the primary branch.

yvonnetangsu
yvonnetangsu approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG - I don't see any difference in the output (which is good)

@sherakama sherakama merged commit 75b9a89 into v7 May 7, 2021
@sherakama sherakama deleted the ADAPT-1771 branch May 7, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

@rebeccahongsf rebeccahongsf Awaiting requested review from rebeccahongsf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherakama @yvonnetangsu