Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-000: Move Tailwind plugins from devdependencies to dependencies #818

Merged
merged 5 commits into from
Apr 20, 2021
Merged

ADAPT-000: Move Tailwind plugins from devdependencies to dependencies #818

merged 5 commits into from
Apr 20, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Apr 20, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Move Tailwind plugins to dependencies.
  • We need to use these plugins in SAA homesite for the JIT mode.

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@yvonnetangsu yvonnetangsu changed the base branch from master to v7 April 20, 2021 19:39
@yvonnetangsu yvonnetangsu changed the title Adapt-000 Move Tailwind and plugins from devdependencies to dependencies Adapt-000 Move Tailwind plugins from devdependencies to dependencies Apr 20, 2021
@yvonnetangsu yvonnetangsu requested a review from sherakama April 20, 2021 19:51
sherakama
sherakama approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@sherakama sherakama changed the title Adapt-000 Move Tailwind plugins from devdependencies to dependencies ADAPT-000: Move Tailwind plugins from devdependencies to dependencies Apr 20, 2021
@sherakama sherakama merged commit e17947f into v7 Apr 20, 2021
@sherakama sherakama deleted the ADAPT-000-tw-plugins branch April 20, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama