New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish up global footer #802

Merged

sherakama merged 2 commits into v7 from v7-global-footer

Feb 12, 2021

Member

yvonnetangsu commented Feb 12, 2021

READY FOR REVIEW

Summary

Finish up building global footer in preview page using TW classes only (for testing, then copy style to Decanter-React)
It's not an exact duplicate of the current global footer but it's very close (modify slightly to work with TW)

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Look at global footer at the bottom and test every breakpoint.

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist


          finish up global footer styles

52904a1

yvonnetangsu changed the base branch from master to v7

February 12, 2021 09:28


          fixup

993f1fa

yvonnetangsu requested a review from sherakama

February 12, 2021 09:42

sherakama approved these changes

View reviewed changes

Member

sherakama left a comment

That looks pretty darned good to me

sherakama merged commit bd96136 into v7

sherakama deleted the v7-global-footer branch

February 12, 2021 17:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet