Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT-000: Link color utility #800

Merged
merged 6 commits into from
Feb 11, 2021
Merged

ADAPT-000: Link color utility #800

merged 6 commits into from
Feb 11, 2021

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Feb 11, 2021

READY FOR REVIEW

Summary

  • For Discussion
  • This is to tackle changing backgrounds, text-color, and link color on the wrapper container.

Needed By (Date)

  • Whenever

Urgency

  • None

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@sherakama sherakama changed the base branch from master to v7 February 11, 2021 07:14
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.... I think this would be useful as long as we use it carefully since it would override a utility class directly place on a link that's within that parent with the su-link-xx class. Nice tool for those WYSIWYG for sure though. GTG - we can always tweak later if we need to.
Screen Shot 2021-02-11 at 9 42 25 AM

@sherakama
Copy link
Member Author

Yeah, I am not super fond of this approach but lacking the ability to get access to the individual links in something like a wysiwyg this might be a good enough get out of jail free card.

@sherakama
Copy link
Member Author

After a little more research this morning I am not finding anything to influence me in a different direction at this point. Merge and use with caution for now.

@sherakama sherakama changed the title Link color utility ADAPT-000: Link color utility Feb 11, 2021
@sherakama sherakama merged commit 55e7b90 into v7 Feb 11, 2021
@sherakama sherakama deleted the link-color-utility branch February 11, 2021 18:14
@yvonnetangsu
Copy link
Member

Sounds good to me - thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants