Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT 1756 - Continuous v7 prep work #795

Merged
merged 7 commits into from
Feb 4, 2021
Merged

ADAPT 1756 - Continuous v7 prep work #795

merged 7 commits into from
Feb 4, 2021

Conversation

yvonnetangsu
Copy link
Member

NOT READY

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

…eme because no components now; add placeholder colors back because we use it
@yvonnetangsu
Copy link
Member Author

Screen Shot 2021-02-03 at 10 26 46 PM
👀 I did npm run publish - should I try something else instead? @sherakama

@sherakama
Copy link
Member

I think we may have been using npm run build so that the css is readable and usable until we get documentation about all the classes.

@sherakama
Copy link
Member

These look good. I am happy to keep them rolling in if you're ready.

@sherakama sherakama temporarily deployed to Tugboat February 4, 2021 17:59 Destroyed
@yvonnetangsu
Copy link
Member Author

These look good. I am happy to keep them rolling in if you're ready.

@sherakama I saw your comment late so I pushed some more stuff before the dev chat. I actually removed the whole "button" folder in components in one commit, since we have html <button> styles in the base css so those are taken care of if people want their buttons to look somewhat decent. What do you think?

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama
Copy link
Member

If we bring the su-button back later we can. For those that want to use just the utility classes and not the base styles.

@yvonnetangsu yvonnetangsu merged commit 0a21690 into v7 Feb 4, 2021
@yvonnetangsu yvonnetangsu deleted the ADAPT-1756-v7-misc branch February 4, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants