Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7 colors #787

Merged
merged 5 commits into from
Jan 12, 2021
Merged

V7 colors #787

merged 5 commits into from
Jan 12, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Jan 11, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Update v7 color variables. Add Digital Green, replace Fog with Foggy (old Fog color is now su-color-foggy-light). Bright Blue is now Digital Blue.

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Look at code

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 10:50 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 10:53 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 10:58 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 22:19 Destroyed
@sherakama
Copy link
Member

@yvonnetangsu How does this relate to #694?

@yvonnetangsu
Copy link
Member Author

yvonnetangsu commented Jan 12, 2021 •
edited
Loading

@yvonnetangsu How does this relate to #694?

#694 looks stale to me - those colors name mentioned have since been changed. However, the colors themselves or similar updated versions of them are in v7 branch but with different new names (@kerri-augenstein suggested some of these changes)

@sherakama
Copy link
Member

Can we close #694 then in favor of this one?

@yvonnetangsu
Copy link
Member Author

Can we close #694 then in favor of this one?

Yes, I believe so. I'll ping @katrialesser tomorrow and let her know since she was working on #694. The new colors are in branch v7 and in the v6 PR so she'll be able to pull from either if the colors are needed.

sherakama
sherakama approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama sherakama mentioned this pull request Jan 12, 2021
Closed
@yvonnetangsu yvonnetangsu merged commit d448d37 into v7 Jan 12, 2021
@yvonnetangsu yvonnetangsu deleted the v7-colors branch January 12, 2021 19:09
@yvonnetangsu
Copy link
Member Author

@sherakama Think we could cut a new release maybe after merging Rebecca's branch?

@sherakama
Copy link
Member

Sure. Can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama