Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEC-000: Update file-loader public path in Webpack Config #786

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Jan 8, 2021

READY FOR REVIEW

Summary

  • When creating my own react app, I kept encountering a @font-face error:
    image

Needed By (Date)

  • n/a

Urgency

  • low

Steps to Test

Set up a create-react-app or clone my repo

  1. Pull this branch to your local
  2. Within the decanter repo, do an npm link
  3. Switch over to your create-react-app directory and do an npm link decanter to link your local decanter repository.
  4. Run npm start.
  5. No font error should appear.

Gotchas — If you create your own react app, you will want to make sure you're using the same npm version as the decanter v7 repo.

See Also

@sherakama sherakama changed the title DEC-000 Update file-loader public path in Webpack Config DEC-000: Update file-loader public path in Webpack Config Jan 26, 2021
@sherakama sherakama merged commit eafb97e into v7 Jan 26, 2021
@sherakama sherakama deleted the DEC-000--assets-fix branch January 26, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants