Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new colors from identity guide and deprecate old color #768

Merged
merged 20 commits into from
Jan 14, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Oct 17, 2020

READY FOR REVIEW

Summary

  • Adding new identity Guide colors to v6 https://identity.stanford.edu/design-elements/color/
  • Deprecate colors that will be removed (no longer in Identity Guide)
  • There are some colors that get to stay but have new names (added deprecation message)
  • Update our color maps (core, nav, alerts) to use new color names and make sure alert component pulls colors from color map.
  • Following proper sassdoc convention, remove $ sign in the @name field for the variable, add @type Color to all color variables.
    Note: I have tested this branch for the Redwood WP repo and the colors look normal to me.
    Note2: The variable for color Fog (and its variants) is called $su-color-foggy since we had $su-color-fog (which has become $su-color-foggy-light in v7) in v6 which was used very frequently. We discussed this in a Decanter meeting and I feel like this option could avoid some confusion in code.

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Look at the files changed
  2. Make sure to expand (click "Load diff" under the file, in the GitHub Files changed tab) to see below file, since that's where most of the new code is:
    core/src/scss/utilities/variables/core/_colors.scss
  3. Also check the color map scss files and see that they're using the new color variables properly
  4. You can also test this branch on one of your projects that uses Decanter by setting the branch to
    git://github.com/SU-SWS/decanter.git#611-new-colors

Affected Projects or Products

  • many things that uses decanter - d8, Redwood etc

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@sherakama sherakama temporarily deployed to Tugboat October 17, 2020 22:38 Destroyed
@sherakama sherakama temporarily deployed to Tugboat October 17, 2020 22:55 Destroyed
@sherakama sherakama temporarily deployed to Tugboat October 18, 2020 05:22 Destroyed
@github-actions github-actions bot added size/l and removed size/m labels Oct 18, 2020
@sherakama sherakama temporarily deployed to Tugboat October 21, 2020 17:21 Destroyed
@sherakama sherakama temporarily deployed to Tugboat October 21, 2020 18:20 Destroyed
@sherakama sherakama temporarily deployed to Tugboat November 5, 2020 19:17 Destroyed
@github-actions github-actions bot added size/xl and removed size/l labels Nov 5, 2020
@sherakama sherakama temporarily deployed to Tugboat November 10, 2020 22:56 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 19:04 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 19:26 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 19:53 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 20:25 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 21:16 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 21:42 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 21:59 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 11, 2021 22:46 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 13, 2021 20:44 Destroyed
* master:
  Back to dev.
  6.2.1
  D8CORE-2529: changing the condition that makes the link not appear (#775)
  Back to dev.
  Different way of setting up modular spacing (#704)

# Conflicts:
#	DEPRECATIONS.md
#	core/dist/css/decanter.css
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the big lift.

@sherakama
Copy link
Member

Where is tugboat on this?

@sherakama sherakama temporarily deployed to Tugboat January 14, 2021 05:46 Destroyed
@yvonnetangsu
Copy link
Member Author

yvonnetangsu commented Jan 14, 2021

Where is tugboat on this?

Thanks for reviewing! Looks like Tugboat is back. It's been over quota for me for a while now so I just assumed that it's dead - looks like you revived it 😃

@yvonnetangsu
Copy link
Member Author

Took a look at the tugboat build and things look ok so I'm going to merge.

@yvonnetangsu yvonnetangsu merged commit ad1fffb into master Jan 14, 2021
@yvonnetangsu yvonnetangsu deleted the 611-new-colors branch January 14, 2021 07:37
@rebeccahongsf rebeccahongsf linked an issue Aug 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update colors on Color page when Identity is complete
2 participants