-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new colors from identity guide and deprecate old color #768
Conversation
… su-color-fog, deprecate color Clay
…sun which is not in new palette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for the big lift.
Where is tugboat on this? |
Thanks for reviewing! Looks like Tugboat is back. It's been over quota for me for a while now so I just assumed that it's dead - looks like you revived it 😃 |
Took a look at the tugboat build and things look ok so I'm going to merge. |
READY FOR REVIEW
Summary
@name
field for the variable, add@type Color
to all color variables.Note: I have tested this branch for the Redwood WP repo and the colors look normal to me.
Note2: The variable for color Fog (and its variants) is called
$su-color-foggy
since we had$su-color-fog
(which has become$su-color-foggy-light
in v7) in v6 which was used very frequently. We discussed this in a Decanter meeting and I feel like this option could avoid some confusion in code.Needed By (Date)
Urgency
Steps to Test
core/src/scss/utilities/variables/core/_colors.scss
git://github.com/SU-SWS/decanter.git#611-new-colors
Affected Projects or Products
Associated Issues and/or People
@mention
them here)See Also