Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-2536: adding aria-label #716

Merged
merged 13 commits into from
Sep 17, 2020
Merged

D8CORE-2536: adding aria-label #716

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
319ed7d
D8CORE-2536: adding aria-label
cjwest Aug 17, 2020
79f81b2
fixup
cjwest Aug 18, 2020
acf8f77
D8CORE-2536: adding external link template
cjwest Aug 18, 2020
22f9cfc
D8CORE-2536: Added external_link_text variable for easier maintenance
cjwest Aug 18, 2020
e89577f
fixup
cjwest Aug 18, 2020
91a6bc7
D8CORE-2536: need to hide it visually
cjwest Aug 18, 2020
43016af
D8CORE-2536: use SASS for styling the external link
cjwest Aug 18, 2020
ec82bb3
D8CORE-2536: update to extternal links solution
cjwest Aug 20, 2020
bd55cc1
Update core/src/templates/components/global-footer/global-footer.twig
sherakama Sep 1, 2020
6e3a8aa
Update core/src/templates/components/global-footer/global-footer.twig
sherakama Sep 1, 2020
54f04a2
D8CORE-2536: adding 'link is external' to all links in the global foo…
cjwest Sep 15, 2020
93bb7fa
fixup
cjwest Sep 16, 2020
179c00f
fixup
cjwest Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,910 changes: 1,909 additions & 1 deletion core/dist/css/decanter-grid.css
View file
Open in desktop

Large diffs are not rendered by default.

7,088 changes: 7,086 additions & 2 deletions core/dist/css/decanter.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions core/dist/js/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,11 @@
"../assets/plus-white.svg": "../assets/plus-white.svg",
"../assets/video.svg": "../assets/video.svg",
"decanter-grid.css": "../css/decanter-grid.css",
"decanter-grid.css.map": "../css/decanter-grid.css.map",
"decanter-no-markup.js": "decanter-no-markup.js",
"decanter-no-markup.js.map": "decanter-no-markup.js.map",
"decanter.css": "../css/decanter.css",
"decanter.css.map": "../css/decanter.css.map",
"decanter.js": "decanter.js",
"decanter.js.map": "decanter.js.map"
}
3,554 changes: 3,553 additions & 1 deletion core/dist/js/decanter-no-markup.js
View file
Open in desktop

Large diffs are not rendered by default.

3,568 changes: 3,567 additions & 1 deletion core/dist/js/decanter.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions core/src/scss/components/global-footer/_global-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@
flex-grow: 1;
}

.su-global-footer__link--external {
sherakama marked this conversation as resolved.
Show resolved Hide resolved
@include hide-visually;
}

.su-global-footer__menu {
@include margin(0 0 1rem);
Expand Down
25 changes: 15 additions & 10 deletions core/src/templates/components/global-footer/global-footer.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
{% if template_path_logo is empty -%}
{%- set template_path_logo = "@decanter/components/logo/logo.twig" -%}
{%- endif %}
{% if external_link_text is empty -%}
{%- set external_link_text -%}
<span class="su-global-footer__link--external">(link is external)</span>
sherakama marked this conversation as resolved.
Show resolved Hide resolved
{% endset %}
{%- endif %}

<div class="su-global-footer {{ modifier_class }}">
<div class="su-global-footer__container">
Expand All @@ -20,24 +25,24 @@
<div class="su-global-footer__content">
<nav aria-label="global footer menu">
<ul class="su-global-footer__menu su-global-footer__menu--global">
<li><a href="https://www.stanford.edu">Stanford Home</a></li>
<li><a href="https://visit.stanford.edu/plan/">Maps &amp; Directions</a></li>
<li><a href="https://www.stanford.edu/search/">Search Stanford</a></li>
<li><a href="https://emergency.stanford.edu">Emergency Info</a></li>
<li><a href="https://www.stanford.edu">Stanford Home {{ external_link_text }}</a></li>
sherakama marked this conversation as resolved.
Show resolved Hide resolved
<li><a href="https://visit.stanford.edu/plan/">Maps &amp; Directions {{ external_link_text }}</a></li>
<li><a href="https://www.stanford.edu/search/">Search Stanford {{ external_link_text }}></a></li>
<li><a href="https://emergency.stanford.edu">Emergency Info {{ external_link_text }}</a></li>
</ul>
<ul class="su-global-footer__menu su-global-footer__menu--policy">
<li><a href="https://www.stanford.edu/site/terms/"
title="Terms of use for sites">Terms of Use</a></li>
title="Terms of use for sites">Terms of Use {{ external_link_text }}</a></li>
<li><a href="https://www.stanford.edu/site/privacy/"
title="Privacy and cookie policy">Privacy</a></li>
title="Privacy and cookie policy">Privacy {{ external_link_text }}</a></li>
<li><a href="https://uit.stanford.edu/security/copyright-infringement"
title="Report alleged copyright infringement">Copyright</a></li>
title="Report alleged copyright infringement">Copyright {{ external_link_text }}</a></li>
<li><a href="https://adminguide.stanford.edu/chapter-1/subchapter-5/policy-1-5-4"
title="Ownership and use of Stanford trademarks and images">Trademarks</a></li>
title="Ownership and use of Stanford trademarks and images">Trademarks {{ external_link_text }}</a></li>
<li><a href="http://exploredegrees.stanford.edu/nonacademicregulations/nondiscrimination/"
title="Non-discrimination policy">Non-Discrimination</a></li>
title="Non-discrimination policy">Non-Discrimination {{ external_link_text }}</a></li>
<li><a href="https://www.stanford.edu/site/accessibility"
title="Report web accessibility issues">Accessibility</a></li>
title="Report web accessibility issues">Accessibility {{ external_link_text }}</a></li>
sherakama marked this conversation as resolved.
Show resolved Hide resolved
</ul>
</nav>
<div class="su-global-footer__copyright">
Expand Down