Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-expanded="false" to main nav parent links in the twig template #681

Merged
merged 1 commit into from
May 27, 2020

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented May 12, 2020

READY FOR REVIEW

Summary

  • Had a consulting session with Level Access. They suggested adding aria-expanded="false" to parent links (the ones that you click to trigger a drop down menu to open) in our Main Nav on load. Currently, the aria-expanded attribute is added only after a parent link has been clicked on.

Needed By (Date)

  • N/A

Urgency

  • Not urgent but sooner the better

Steps to Test

  • Not sure what's the best way to test since tugboat is over quota. I did the same modification in UComm's Redwood WP template and this change works while keeping all current JS working as expected. Might want to make sure this doesn't break anything on the Drupal side (should be fairly low risk but just in case).

Affected Projects or Products

  • Decanter
  • Redwood, UComm sites

Associated Issues and/or People

…te so the attribute is there on load; update package-lock.json to current decanter version
@sherakama sherakama merged commit 6f58949 into master May 27, 2020
@sherakama sherakama deleted the 680-main-nav-aria branch May 27, 2020 17:51
@sherakama
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants