New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D8CORE-1259: Add cool grey color variables and update package.json #614

Merged

sherakama merged 2 commits into master from D8CORE-1259

Feb 6, 2020

Member

sherakama commented Feb 6, 2020

READY FOR REVIEW

Summary

Updates package.json for newer versions
Adds:

#7a7b7e = $su-color-cool-grey-75
#a6a7a9 = $su-color-cool-grey-50
#D2D3D4 = $su-color-cool-grey-25
#E5E5E5 = $su-color-cool-grey-15

Review By (Date)

Feb 13th please.

Urgency

Low.

Steps to Test

Review tugboat's build of the SASS docs for the variables.
Review code.

Affected Projects or Products

D8CORE

Associated Issues and/or People

D8CORE
@kerri-augenstein FYI.

See Also

PR Checklist


          D8CORE-1259: Add cool grey color variables and update package.json

069ddf4

sherakama requested review from jenbreese and yvonnetangsu

February 6, 2020 21:56

sherakama assigned yvonnetangsu

sherakama temporarily deployed to Tugboat

February 6, 2020 21:56

Destroyed


          Remove obsoleted colors KSS file.

0a5cdef

yvonnetangsu approved these changes

View reviewed changes

Member

yvonnetangsu left a comment

Perfect - I checked the color values with the eyedropper and it's GTG! Thanks!

sherakama merged commit 6c92eb4 into master

sherakama deleted the D8CORE-1259 branch

February 6, 2020 23:58

Member Author

sherakama commented Feb 6, 2020

You're the best. Thanks for the quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet