Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conditionals in template to support an empty cell2 #601

Merged
merged 21 commits into from
Jan 9, 2020
Merged

Improve conditionals in template to support an empty cell2 #601

merged 21 commits into from
Jan 9, 2020

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Jan 7, 2020 •
edited
Loading

READY FOR REVIEW

Summary

  • Improves conditionals for lockup's cell2 region to stop rendering empty tags.
  • Since the KSS generator is gone we need a new preview environment. I stood up a build that mimics the netlify build. Images are still an issue but it is a good start.

Needed By (Date)

  • ?

Urgency

  • Low, really only for su-lockup--option-r

Steps to Test

  1. Check out this branch.
  2. TBD

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:18 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:29 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:30 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:35 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:36 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:41 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:45 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 07:51 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:00 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:02 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:04 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:14 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:15 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:28 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:30 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:41 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:43 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:44 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 08:58 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 7, 2020 17:47 Destroyed
@sherakama sherakama temporarily deployed to Tugboat January 9, 2020 04:59 Destroyed
@sherakama sherakama requested a review from yvonnetangsu January 9, 2020 05:02
yvonnetangsu
yvonnetangsu approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. GTG!

@sherakama sherakama merged commit 9171104 into master Jan 9, 2020
@sherakama sherakama deleted the lockup-option-r-cell2 branch January 9, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

Assignees

@yvonnetangsu yvonnetangsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherakama @yvonnetangsu