Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SassDoc — Regroup Sass #599

Merged
merged 3 commits into from
Dec 20, 2019
Merged

SassDoc — Regroup Sass #599

merged 3 commits into from
Dec 20, 2019

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Dec 20, 2019 •
edited
Loading

READY FOR REVIEW

Summary

  • Reorganizing and grouping the Sass

Needed By (Date)

  • Friday, 12/20/19

Urgency

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • SassDoc

Associated Issues and/or People

Accessibility Checks

  • What accessibility testing has been done on the work in this PR? (WAVE, AMP, etc.)

See Also

@rebeccahongsf rebeccahongsf self-assigned this Dec 20, 2019
@sherakama sherakama temporarily deployed to Tugboat December 20, 2019 04:59 Destroyed
@sherakama sherakama temporarily deployed to Tugboat December 20, 2019 05:11 Destroyed
@rebeccahongsf
Copy link
Contributor Author

Side Note:
core/src/scss/utilities/mixins/card/_card.scss is causing undefined Sassdocs categorized in General > CSS (see SassDoc first sidebar).

@sherakama sherakama temporarily deployed to Tugboat December 20, 2019 05:22 Destroyed
@buttonwillowsix
Copy link

So glad you figured out where the css stuff was coming from!

buttonwillowsix
buttonwillowsix approved these changes Dec 20, 2019
View reviewed changes
Copy link

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Much cleaner, and glad you found the css junk-maker!

@sherakama sherakama merged commit 66c16b5 into v6 Dec 20, 2019
@sherakama sherakama deleted the sassdoc-grouping branch December 20, 2019 16:52
@sherakama
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buttonwillowsix buttonwillowsix buttonwillowsix approved these changes

@sherakama sherakama Awaiting requested review from sherakama

Assignees

@rebeccahongsf rebeccahongsf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebeccahongsf @buttonwillowsix @sherakama