Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update big and small paragraph descriptions #595

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Update big and small paragraph descriptions #595

merged 1 commit into from
Dec 14, 2019

Conversation

rebeccahongsf
Copy link
Contributor

READY FOR REVIEW

Summary

Needed By (Date)

  • End of Sprint

Urgency

  • How critical is this PR?

Steps to Test

Assuming your local decanter is linked to your local decanter-web

  1. Pull this branch to local.
  2. Switch to your local decanter-web,
  3. Run npm run sassdoc
  4. Run npm start
  5. Go to http://localhost:3000/docs/scss/index.html

Affected Projects or Products

  • Sass Docs
  • Decanter Website

Associated Issues and/or People

See Also

@rebeccahongsf rebeccahongsf self-assigned this Dec 12, 2019
@sherakama sherakama temporarily deployed to Tugboat December 12, 2019 22:31 Destroyed
@buttonwillowsix buttonwillowsix mentioned this pull request Dec 12, 2019
Closed
@sherakama sherakama changed the base branch from metalsmith to v6 December 14, 2019 00:07
@sherakama sherakama force-pushed the dec-559-paragraph-fix branch from 55343d3 to 883bc24 Compare December 14, 2019 00:14
@sherakama sherakama temporarily deployed to Tugboat December 14, 2019 00:14 Destroyed
@sherakama sherakama merged commit 33f1e3c into v6 Dec 14, 2019
@sherakama sherakama deleted the dec-559-paragraph-fix branch December 14, 2019 00:14
yvonnetangsu added a commit that referenced this pull request Dec 16, 2019
@yvonnetangsu
Merge branch 'v6' into 435-icon-card
2c3383c 
* v6:
  Small and big descriptions. (#595)
  Metalsmith (#561)

# Conflicts:
#	core/src/scss/utilities/mixins/index.scss
#	core/src/scss/utilities/placeholders/components/_card.scss
#	core/src/scss/utilities/variables/core/_core-color-maps.scss
#	core/src/templates/components/card/card.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

@buttonwillowsix buttonwillowsix Awaiting requested review from buttonwillowsix

Assignees

@rebeccahongsf rebeccahongsf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahongsf @sherakama