Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secondary nav js #529

Merged
merged 8 commits into from
Oct 30, 2019
Merged

Secondary nav js #529

merged 8 commits into from
Oct 30, 2019

Conversation

sherakama
Copy link
Member

NOT READY

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@sherakama sherakama temporarily deployed to Tugboat October 29, 2019 16:12 Destroyed
@sherakama sherakama changed the base branch from master to secondary-nav October 29, 2019 16:12
@sherakama sherakama mentioned this pull request Oct 29, 2019
Merged
@sherakama sherakama temporarily deployed to Tugboat October 29, 2019 17:28 Destroyed
@yvonnetangsu
Copy link
Member

@sherakama , is this ready for review?

@sherakama
Copy link
Member Author

No, not yet. Lots to do still.

@sherakama sherakama temporarily deployed to Tugboat October 29, 2019 22:35 Destroyed
@sherakama sherakama temporarily deployed to Tugboat October 30, 2019 06:17 Destroyed
@sherakama sherakama temporarily deployed to Tugboat October 30, 2019 06:21 Destroyed
@sherakama sherakama merged commit a90d61a into secondary-nav Oct 30, 2019
@sherakama sherakama deleted the secondary-nav-js branch October 30, 2019 06:23
@sherakama sherakama restored the secondary-nav-js branch October 30, 2019 20:16
@sherakama sherakama deleted the secondary-nav-js branch December 20, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherakama @yvonnetangsu