Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use percentage for html root font size instead of px #521

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Oct 23, 2019

READY FOR REVIEW

Summary

  • Use 62.5% for html font size instead of 10px, so people who set font size preferences in their browser can see elements scaling up.

Needed By (Date)

  • Sooner the better

Urgency

  • Not urgent

Steps to Test

  1. Pull this branch and compile styleguide
  2. Check that no rendered font sizes has changed compared to the live decanter site.

Affected Projects or Products

  • Decanter

@sherakama sherakama temporarily deployed to Tugboat October 23, 2019 21:13 Destroyed
@yvonnetangsu
Copy link
Member Author

I used Diffy to compare the live Decanter site to the tugboat URL. The only difference was caused by the addition of the local footer in the tugboat link. So I think we can safely make that change to the html based font size to use %.

Screen Shot 2019-10-24 at 3 29 59 PM

@sherakama sherakama merged commit 3d8e75e into v6 Oct 25, 2019
@sherakama sherakama deleted the html-fontsize branch October 25, 2019 17:09
@sherakama
Copy link
Member

Thanks for checking!

@yvonnetangsu
Copy link
Member Author

@sherakama , is it possible to also merge this into master?

@sherakama sherakama restored the html-fontsize branch October 25, 2019 17:20
@sherakama sherakama temporarily deployed to Tugboat October 25, 2019 17:21 Destroyed
@yvonnetangsu yvonnetangsu deleted the html-fontsize branch October 25, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants