New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v12.4.0 support for node-sass #438

Merged

JBCSU merged 1 commit into master from node-12

Jun 11, 2019

Member

sherakama commented Jun 11, 2019

READY FOR REVIEW

Summary

Update node-sass version to support node 12
support for node.js 12.x sass/node-sass#2632
Not everyone is using NVM

Needed By (Date)

End of the week?

Urgency

low

Steps to Test

Check out this branch
Run npm install
Ensure version 4.12.0 gets installed

Affected Projects or Products

NPM commands

Associated Issues and/or People

See Also

PR Checklist


          Update package.json

baff221

sherakama requested review from JBCSU and yvonnetangsu

June 11, 2019 18:00

sherakama assigned JBCSU

sherakama changed the title ~~Update package.json~~ Node v12.4.0 support for node-sass

yvonnetangsu approved these changes

View reviewed changes

Member

yvonnetangsu left a comment

I did npm install and node-sass 4.12 was installed. GTG!

JBCSU approved these changes

View reviewed changes

Collaborator

JBCSU left a comment

A few of my packages updated. A rebuild of the assets and the style guide worked, so all seems good to me.

JBCSU merged commit 40bdc72 into master

JBCSU deleted the node-12 branch

June 11, 2019 22:36

yvonnetangsu added a commit that referenced this pull request


          Merge branch 'master' into 423-svg-icon-test

328db3a

* master:
  424 default link style (#427)
  Update package.json (#438)
  Set up color maps for Decanter and refactor main nav colors to refer to color maps (#420)

yvonnetangsu added a commit that referenced this pull request


          Merge branch 'master' into 222-masthead

c353fcd

* master:
  Use svg icons as "mask" so their colors could be changed using CSS background-color (#426)
  424 default link style (#427)
  Update package.json (#438)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet