Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Quotes #41

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Smart Quotes #41

merged 1 commit into from
Apr 5, 2017

Conversation

kgcreative
Copy link
Contributor

@kgcreative kgcreative commented Apr 2, 2017

READY

There is full browser support for <blockquote> and <q> elements. Apparently nobody has really bothered to implement them, but they are there, in the spec, being awesome.

This implements double and single typographical quotes around <blockquote> and <q> elements, with correct double first, then nested single inside double properties. This means when quoting someone, s, instead of so and so said "this is crazy!", you can say so and so said <q>this is crazy!</q>

…rently nobody has really bothered to implement them, but they are there, in the spec, being awesome.

This implements double and single typographical quotes around <blockquote> and <q> elements, with correct double first, then nested single inside double properties. This means when quoting someone, s, instead of `so and so said “this is crazy!”`, you can say `so and so said <q>this is crazy!</q>`
@kgcreative kgcreative requested a review from sherakama April 2, 2017 02:00
@sherakama sherakama merged commit 31277b4 into master Apr 5, 2017
@sherakama sherakama deleted the smart-quotes branch April 5, 2017 23:45
kgcreative pushed a commit that referenced this pull request Apr 6, 2017
* master:
  There is full browser support for <blockquote> and <q> elements. Apparently nobody has really bothered to implement them, but they are there, in the spec, being awesome. (#41)
  !fixup - BEM color names

# Conflicts:
#	core/utilities/variables/_color.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants