Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more to changelog #364

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Added more to changelog #364

merged 2 commits into from
Mar 27, 2019

Conversation

yvonnetangsu
Copy link
Member

READY FOR REVIEW

Summary

  • Added a little more detail as @JBCSU suggested

Needed By (Date)

  • End of today

Urgency

  • ASAP

Steps to Test

  1. Look at the changelog changes.

Affected Projects or Products

  • Decanter

@yvonnetangsu yvonnetangsu requested review from sherakama and JBCSU March 27, 2019 17:54
@yvonnetangsu yvonnetangsu changed the title Added a bit more details Added more to changelog Mar 27, 2019
JBCSU
JBCSU approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator

@JBCSU JBCSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these changes as is. Just a small question about indenting. Whatever you decide about it is fine.

CHANGELOG.md Outdated Show resolved Hide resolved
@sherakama sherakama merged commit e8f9eb3 into master Mar 27, 2019
@sherakama sherakama deleted the changelog-details branch March 27, 2019 22:38
yvonnetangsu added a commit that referenced this pull request Jun 11, 2019
@yvonnetangsu
Merge branch 'master' into 222-masthead
2d83f76 
* master: (44 commits)
  Set up color maps for Decanter and refactor main nav colors to refer to color maps (#420)
  Move PR template (#416)
  Fix skiplink target so it doesn't take up space and cause overflow (#415)
  Release 5.0.1 (#417)
  Fix CSS grid gaps not displaying on Edge issue and other minor grid related issues (#413)
  More link fixup (#388)
  forgot to rebuild .js after final lint fixes (#387)
  add openNav, closeNav, openSubnav, closeSubnav events (#379)
  Fix main nav color variants and work with new linting rules (#380)
  add favicon to style guide (#377)
  Adjust linters. (#370)
  update readme.md to match Scott's intro on homepage.md (#371)
  Update README.md (#369)
  move the images we need for the styleguide's homepage into kss-assets (#368)
  Update README.md (#367)
  Update UPGRADE.md (#363)
  package.locl.json file is back (#366)
  Added more to changelog (#364)
  Update homepage.md (#362)
  90 basic webpack (#334)
  ...

# Conflicts:
#	core/scss/components/index.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBCSU JBCSU JBCSU approved these changes

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvonnetangsu @sherakama @JBCSU