Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to search icon in main-nav files #359

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

yvonnetangsu
Copy link
Member

READY FOR REVIEW

Summary

  • We changed the icon in site-search button to background image. Now we need to remove the reference to the icon image in main-nav.twig and json.
  • Added a little documentation for Noto Sans that it's the Sanskrit subset and should only be used when one needs Sanskrit support.

Needed By (Date)

  • Before v5

Urgency

  • ASAP

Steps to Test

  1. Pull this branch and run grunt styleguide
  2. Check that the .su-main-nav--mobile-search variant looks ok when in xs-md breakpoints.
  3. Check that the reference to the search icon has been removed in main-nav.twig and json.
  4. Check that the added documentation under Fonts - Noto Sans is ok

Affected Projects or Products

  • Decanter

Associated Issues and/or People

@yvonnetangsu
Copy link
Member Author

@JBCSU , let me know if I missed anything else with the site-search icon.

@josephgknox , let me know if the added documentation for Noto Sans makes sense. I kind of bundled that in with the site-search icon tweaks.

Thanks!!

Copy link
Collaborator

@JBCSU JBCSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@sherakama sherakama merged commit bf6a773 into master Mar 26, 2019
@sherakama sherakama deleted the mobile-search-fix branch March 26, 2019 22:10
@josephgknox
Copy link

Yay -- already merged. Thanks, @yvonnetangsu!

JBCSU added a commit that referenced this pull request Mar 26, 2019
* master:
  remove reference to search icon in main-nav twig and json; add documentation to Noto Sans (#359)
  Refactor site-search so the icon can be turned into inline CSS by Webpack (#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants