Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

188 Button Tweak #287

Merged
merged 7 commits into from
Jan 28, 2019
Merged

188 Button Tweak #287

merged 7 commits into from
Jan 28, 2019

Conversation

josephgknox
Copy link

READY FOR REVIEW

Summary

  • Add more padding to the bottom on button for better optical alignment

Needed By (Date)

  • N/A

Urgency

  • N/A

Steps to Test

  1. Pull this branch
  2. Run grunt styleguide
  3. Ensure that all three button types have slightly more padding below than above their content

Affected Projects or Products

  • Decanter

Associated Issues and/or People

See Also

@josephgknox josephgknox mentioned this pull request Jan 23, 2019
Closed
@josephgknox josephgknox requested a review from sherakama January 23, 2019 19:06
sherakama
sherakama reviewed Jan 23, 2019
View reviewed changes
core/css/decanter-grid.css Outdated
@@ -1,37 +1,26 @@
html {
-webkit-box-sizing: border-box;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Why is the prefixing missing in your compile?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sir. grunt sass doesn't compile the prefixes. Running grunt styleguide did it.

sherakama
sherakama requested changes Jan 23, 2019
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the button look fine but your sass compiler is missing the browser prefixing.

@sherakama sherakama added this to the Version 5.0.0 milestone Jan 23, 2019
@josephgknox
Copy link
Author

josephgknox commented Jan 24, 2019 •
edited
Loading

@sherakama prefix is back.

k2si

@sherakama
Copy link
Member

@yvonnetangsu this looks good to me. It just needs your blessing.

yvonnetangsu
yvonnetangsu requested changes Jan 25, 2019
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to apologize in advance for being so nit-picky here 😄 .... The buttons look like they have just a tad too much padding at the bottom now. I looked at them with John together and these are the values we like the most - mind taking a look and see if they're ok?

core/scss/utilities/mixins/button/_button-big.scss Outdated Show resolved Hide resolved
core/scss/utilities/mixins/button/_button-primary.scss Outdated Show resolved Hide resolved
core/scss/utilities/mixins/button/_button-secondary.scss Outdated Show resolved Hide resolved
@josephgknox
Copy link
Author

@yvonnetangsu Thanks for confirming with John! These work for me.

@sherakama sherakama merged commit a275dfa into master Jan 28, 2019
@sherakama sherakama deleted the 188-button-tweaks branch January 28, 2019 17:22
yvonnetangsu added a commit that referenced this pull request Jan 29, 2019
@yvonnetangsu
Merge branch 'master' into 72-main-nav
170126d 
* master:
  Fluid centered container. (#286)
  188 Button Tweak (#287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu requested changes

@sherakama sherakama sherakama approved these changes

Assignees

@sherakama sherakama

Labels
None yet
Projects
None yet
Milestone
Version 5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@josephgknox @sherakama @yvonnetangsu