-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
215 Logo lockup #252
Merged
+523
−0
Merged
215 Logo lockup #252
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0970f6f
215: Initial setup of lockup files
yvonnetangsu 9243828
215: Add code for line 2 and line 5 in the site name
yvonnetangsu e30ad87
215: Add variant for 2 lines site name to right of wordmark and CSS f…
yvonnetangsu e0a3932
215: lockup media queries for smaller breakpoints
yvonnetangsu 4009e4e
215: merge master and resolve conflict
yvonnetangsu 37470be
215: Add conditional behavior for the horizontal divider (appears onl…
yvonnetangsu 1586d3a
Merge branch 'master' into 215-lockup
yvonnetangsu 0de811e
215: Codeclimate fix and grid touch up
yvonnetangsu 1e0c5a6
215: cc fix
yvonnetangsu c88342e
215: Add -ms grid properties and fixup
yvonnetangsu 24eaadd
215: Add attributes and modifier_class variables in twig comment
9b150e0
215: fixup
yvonnetangsu 530ebfe
215: Add width:fit-content to limit clickable area to where there is …
yvonnetangsu e647433
215: fixup
JBCSU 2652420
215: fixup
JBCSU 95c2d6b
215: tweak twig comments, line wrap and line height
yvonnetangsu 92c9b6e
215: add styleguide comment
JBCSU 71ccf08
Merge branch 'master' into 215-lockup
JBCSU a7b91fc
remove duplicated markup from lockup template
JBCSU File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215: Add attributes and modifier_class variables in twig comment
Co-Authored-By: yvonnetangsu <[email protected]>
commit 24eaadda76a422e31cf8439817475d6e23725ebd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO,
.su-lockup
,.su-lockup__sitename-line1
,.su-lockup__sitename-line2
and.su-lockup__sitename-line5
are not variants. Those classes are required in all cases in order for the component to render correctly. And indeed they're hardcoded in the template. I would argue for removing them from their respective list of "Available variants." Yvonne said she documented them that way in order to be consistent with existing doc, but we couldn't (quickly) find an example of that. @josephgknox & @sherakama, your thoughts on whether or not these required classes should be documented as "variants"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean, @JBCSU . My proposed tweak would be to list the "defaults" in their own section, and then the variants. @josephgknox and @sherakama , LMK what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I redid the comments in lockup.twig. LMK what you all think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up @JBCSU. I completely agree with you here. @yvonnetangsu thanks for addressing this already. My one (very small) comment would be to move the Default classes for the individual site name lines comment above the Available variant for the lockup comment so that class comments and variant comments are next to one another.