Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decanter 161 grid version v04 #187

Merged
merged 13 commits into from
Aug 16, 2018
Merged

Conversation

bixgomez
Copy link
Contributor

READY FOR REVIEW

Summary

  • Implementing functional Flexbox class-based grid system

Steps to Test

  1. Visit /section-core.html#kssref-core-grid in the style guide
  2. Confirm that the grid performs as expected across all breakpoints, and in IE11

Associated Issues and/or People

@josephgknox
Copy link

josephgknox commented Aug 14, 2018

This looks great, and is very close. A few of things:

  • we talked about changing the class names in our meeting last week. Something like decanter-span[#]. The respective mixin names should change to match as well.
  • currently .decanter-grid is being styled in two places: in scss/core/grid/_grid.scss via the related mixin and in scss/core/grid/_base.scss. These should be consolidated.
  • due to the new class-based system, which is being leveraged in some of the style guide's examples, the "Colors" section is borked. Looks like it just needs the decanter-grid wrapper.
  • the "sourceMappingURL" in the decanter-no-markup file changed (can't seem to identify why?); the string seems to be incorrect.
  • the grid mixins, which are important ones, have not been added to the style guide.
  • the // A playground to test concepts. comment in the scss/core/grid/_grid.scss should be removed.

@bixgomez bixgomez force-pushed the decanter-161--grid-version--v04 branch from ea5260a to 7e7b048 Compare August 16, 2018 07:18
@josephgknox josephgknox merged commit 01a4d91 into master Aug 16, 2018
@josephgknox josephgknox deleted the decanter-161--grid-version--v04 branch August 16, 2018 22:12
@josephgknox josephgknox restored the decanter-161--grid-version--v04 branch August 16, 2018 22:21
josephgknox pushed a commit that referenced this pull request Aug 16, 2018
josephgknox pushed a commit that referenced this pull request Aug 16, 2018
@josephgknox josephgknox deleted the decanter-161--grid-version--v04 branch August 16, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants