New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Tweaks and Fixes #176

Merged

sherakama merged 2 commits into master from tweaks-and-fixes

Jul 23, 2018

josephgknox commented Jul 17, 2018

READY FOR REVIEW

Summary

Very small changes, but are being added so that they don't need to be overrode in project partials every time
removed margin-top from heading 1's
removed the hard-coded font family on buttons

Needed By (Date)

As soon as possible (would unblock some project work)

Urgency

N/A

Steps to Test

Pull this branch
Ensure that tweaks are applied

Affected Projects or Products

decanter
stanford_basic
suhumsci (theme)

Associated Issues and/or People

N/A

See Also

PR Checklist


          remove hard-coding of font family for buttons and rm top margin from h1

6fffc1a

josephgknox requested review from sherakama and JBCSU

July 17, 2018 21:06

Author

josephgknox commented Jul 17, 2018

sherakama approved these changes

View reviewed changes

Member

sherakama left a comment

GTG

Member

sherakama commented Jul 18, 2018

@josephgknox Can you clean up the codeclimate comments before merging.

Author

josephgknox commented Jul 19, 2018

@sherakama I'm feeling like we want to ignore these 4 CC issues, in this case. We would need to add a few extra (and arguably unnecessary) lines to the SCSS and nest deeper to address them. Thoughts?

Member

sherakama commented Jul 19, 2018

@josephgknox all good. But do you really need a.selector? could you get away without the tag on the selector or does some orther css scope blow out the styles?


          rm class attachment to specific element

91b5b8f

josephgknox changed the title ~~remove hard-coding of font family for buttons and rm top margin from h1~~ Small Tweaks and Fixes

Author

josephgknox commented Jul 20, 2018

@sherakama based on our conversation this morning (on Decanter vs Drupal/WP vs theme), I have made the related update (see last commit). This also addressed the CC issues.

sherakama approved these changes

View reviewed changes

sherakama merged commit aae8bff into master

sherakama deleted the tweaks-and-fixes branch

July 23, 2018 18:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet