Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added semibold and other source sans pro font styles that were missing #173

Merged
merged 3 commits into from
Jul 23, 2018

Conversation

josephgknox
Copy link

READY FOR REVIEW

Summary

  • Added missing Source Sans Pro font styles
  • Address gaps between mocks and code output in projects

Needed By (Date)

  • N/A

Urgency

  • N/A

Steps to Test

  1. Pull this branch
  2. Ensure that the new font styles (font-style and font-weight) are available (e.g., font-weight: 900)

Affected Projects or Products

  • Decanter
  • Archaeology

Associated Issues and/or People

  • N/A

See Also

@josephgknox
Copy link
Author

josephgknox commented Jul 13, 2018

Cc: @bixgomez

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@JBCSU JBCSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like all the fonts are downloaded even if they're not used. Is that true, or am I mis-reading something?

Also, should Core > Fonts in the style guide be updated to show all fonts / font variations that are available?

@josephgknox
Copy link
Author

@JBCSU yep, there is a file (or two or three or four) for each of the font variations, and all font variations are downloaded (@font-face) even if they are not used (so that anytime a related variable or mixin is used it works).

I like your idea of showing all the fonts and their variations. I can work on getting that in.

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama
Copy link
Member

I am going to add a backlog ticket to be able to dynamically load fonts so that not everything is loaded all the time. As fonts are one of the heaviest items this would be a nice improvement. Not for the score of this work however.

@josephgknox
Copy link
Author

@JBCSU added all style variations to the example template at Core > Fonts. Heading styles, paragraph styles, and all variations of the font can now be viewed. This space (as well as many others) can use some theming of the style guide itself to reduce spacing and margins between items.

@sherakama thanks for adding that! We're using three Google fonts, so we could use the @import rather than @font-face (so that we don't have to host the fonts at all) if we want to. In either case, the most bulletproof and least heavy option would be best.

@sherakama sherakama merged commit 3b72324 into master Jul 23, 2018
@sherakama sherakama deleted the source-sans-pro-semibold branch July 23, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants