-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bourbon update #115
Bourbon update #115
Changes from 9 commits
023bfad
bbfbafe
940cf82
a9e721f
a37501e
ebb3685
0c6a858
c7253be
755e3b4
f8d16b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Upgrade | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is great. Thanks @josephgknox There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sweet! Thanks for adding the steps to actually receive the update. :) |
||
|
||
Upgrade from version 2.1.0 to 3.0.0 | ||
----------------------------------- | ||
|
||
Version 3.0.0 is a new major version of Decanter. The primary difference between | ||
version 2.1.0 and 3.0.0 is that Bourbon has been updated from version 4.2.7 to | ||
the latest stable version, 5.0.0. | ||
|
||
For details on other changes in this release, as well as details on all | ||
Decanter releases, see [CHANGELOG.md](CHANGELOG.md). | ||
|
||
### Migrating from v4 to v5 of Bourbon | ||
|
||
See Bourbon's documentation overviewing what has changed between these two | ||
versions at https://www.bourbon.io/docs/migrating-from-v4-to-v5/. | ||
|
||
### What's been updated in Decanter | ||
|
||
Only Bourbon mixins and functions being utilized in Decanter thus far needed to | ||
be combed through and updated. | ||
|
||
All deprecated code being used in Decanter from version 4.2.7 of Bourbon has | ||
been updated to leverage and implement the new means of accomplishing the same | ||
thing. These changes are: | ||
|
||
1. Added new method (post-processor) of adding required vendor prefixes: | ||
autoprefixer with postcss. Bourbon 5.0.0 has removed all prefixing features, as | ||
it is no longer best practice for pre-processors like SCSS to handle prefixing. | ||
A new Grunt task, `grunt compile` has been configured. This task compiles All | ||
SCSS to CSS and adds any necessary prefixes to code. | ||
2. The `$weight` and `$style` arguments in the `@font-face` mixin have been | ||
removed. As a result, the mixin now includes one less argument. All fonts being | ||
called with the mixin has been updated with the new implementation. | ||
3. All of the font stack variables are now prefixed with `font-stack-`. The | ||
fallback for all three primary fonts in Decanter leverage these variables. The | ||
new variables has been added to all of the font calls. | ||
|
||
### How to Upgrade Decanter in your project | ||
|
||
1. Check out or pull down the latest version 3 code of Decanter | ||
2. Run npm install to get the newest packages | ||
3. Compile the SCSS |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephgknox: I have now set this to true in order to preserve the sass maps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherakama awesome! I had originally set it to false as the sass task was writing the maps. Based on order of operations (and now that these things happened as part of a single command) this should've been set to true. Thanks!