-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile #11
Compile #11
Conversation
Do we want to add a |
I was playing around with sassdoc and moving the scss files to a folder such as core make it easier for the compiler. I chose the name 'src' for now but core works for me as well. |
|
Changed to core. |
While we are moving things around. I've seen the convention of removing the leading "_" for the roll up file names. eg: /core/utilities/settings/settings.scss I like this as it separates out the file from the other partials. Do you have any objections to this? |
I'm ok with this. I was achieving something similar by having rollups be one level down. By default, sass doesn't compile _underscore files, while it tries to create compiled CSS for non underscore files, so we'd need to test the behavior. |
Regarding the |
I've got some thinking to do about that particular folder. As it does have markup it should only ever be included once in a project but because it uses mixins, extends, and variables from the rest of the project it is going to be difficult to ensure that the includes load the vars, bourbon, and neat in the correct order. If I don't import the requirements then sassdoc yells at me and renders incomplete documentation. |
In my latest refactor, if you include 'settings' - it loads global settings, bourbon, neat, and variables in the correct order. Settings should be included first before anything else. |
Merging for now so we can have some of the file system changes in the master branch. I think this is a good start. Let's test out un _underscored rollups, but at this stage they should be ok. |
Not Ready
But opening in order to start conversation.