Icon postcard block completed with approval from John on the design #104
Conversation
|
Minor tweak to margin call in mixin for consistency; removed two extra spaces in template file. This looks good. |
|
@sherakama let me know if you're good with merging, too. |
| @@ -0,0 +1,10 @@ | |||
| <div class="decanter-icon-block {{ classes }}"> | |||
| <img class="decanter-icon-block__img" src="../../../img/circle.png" alt="Please provide alt text"> | |||
There was a problem hiding this comment.
Please update the src attribute to include a template variable so we can add our own src files when we use this template elsewhere.
Please also do the same with the alt text.
* Quote tweaks (#105) * Created quote element within elements directory based on design Kerri made for the Engineering project * tweak Quote template to make it easier to include directly into themes * don't hardcode path to quote's image * update neat-omega, grunt, grunt-sass, jquery, and associated dependencies (#106) * #107 specify node version (#108) * removed FA from project; updagraded to latest normalize (#101)
josephgknox
force-pushed
the
icon-postcard-block
branch
from
168cd3a to
e1057df
Compare
| @@ -1,6 +1,6 @@ | |||
| <div class="decanter-quote"> | |||
| <img class="decanter-quote__img " src="{{ image }}" alt="{{ altText }}"> | |||
| <div class="decanter-quote__body "> | |||
| <img class="decanter-quote__img" src="{{ imageSource }}" alt="{{ alt }}"> | |||
There was a problem hiding this comment.
Do not use camelCase for variable names
The standard is to use underscore. See: https://twig.symfony.com/doc/2.x/coding_standards.html
change imageSource to image_source or better yet the shorter img_source or even shorter src
|
@sherakama LMK if you think this is ready to merge. |
css/decanter.css
Outdated
| @@ -4,26 +4,34 @@ html { | |||
| *, *::after, *::before { | |||
| box-sizing: inherit; } | |||
|
|
|||
| /*! normalize.css v8.0.0 | MIT License | github.com/necolas/normalize.css */ | |||
| /*! normalize.css v6.0.0 | MIT License | github.com/necolas/normalize.css */ | |||
There was a problem hiding this comment.
Looks like normalize got rolled back to v6 here. I will update and re-compile.
| "image": "../../../img/headshot.jpg", | ||
| "altText": "Jane Doe" | ||
| "name": "John Doe", | ||
| "detail1": "Detail 1", |
There was a problem hiding this comment.
@josephgknox There are no detail variables in this template. What are they used for?
Also, bio is now missing.
|
There were several merge conflicts; I thought I corrected all of them. Must’ve incorrectly mixed some older things with new things. Yay for reviews. Will fix this up! |
|
@sherakama updated the template issue. |
|
@josephgknox, Looks like you re-rolled with normalize 6 again. Run Template changes look good. |
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "Jane Doe", | |||
| "name": "John Doe", | |||
|
💯 |
No description provided.