Skip to content

Commit

Permalink
298-change "sticky-footer" mixin to target <footer> selector (#299)
Browse files Browse the repository at this point in the history
remove parent <footer> element from the Global Footer component and include it instead in kss/builder/decanter/index.twig.  The Global Footer component is now a <section> to be included in a a sites <footer> region.  Also added some comments to global-footer.twig which mirror what are in the brand-bar component.
  • Loading branch information
stocker authored and Joe Knox committed Feb 26, 2019
1 parent 403d237 commit d630c77
Show file tree
Hide file tree
Showing 7 changed files with 101 additions and 93 deletions.
118 changes: 57 additions & 61 deletions core/css/decanter.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions core/scss/components/brand-bar/_brand-bar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@

.su-brand-bar__container {
@include centered-column;
@include grid-media-only('xs') {
@include padding(null 20px);
}
}

.su-brand-bar__logo {
Expand Down
16 changes: 8 additions & 8 deletions core/scss/components/global-footer/_global-footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
//

// Global styles for the global footer.
.global-footer {
.su-global-footer {
@include modular-spacing(1, 'padding-top');
@include modular-spacing(1, 'padding-bottom');
background-color: $color-cardinal-red;
Expand All @@ -28,15 +28,15 @@
}

// Grid settings for footer container.
.global-footer__container {
.su-global-footer__container {
@include centered-column;
@include grid-media('md') {
display: flex;
}
}

// The Logo.
.global-footer__brand {
.su-global-footer__brand {
@include padding(0.5rem null null);
@include modular-spacing(-2, 'margin-bottom');
text-align: center;
Expand All @@ -52,7 +52,7 @@
}
}

.global-footer__content {
.su-global-footer__content {
@include grid-media-only('sm') {
text-align: center;
}
Expand Down Expand Up @@ -86,7 +86,7 @@
}
}

.global-footer__menu {
.su-global-footer__menu {
@include margin(0 0 1rem);
@include padding(0);
list-style-type: none;
Expand Down Expand Up @@ -117,7 +117,7 @@
}
}

.global-footer__menu--global {
.su-global-footer__menu--global {
font-size: 1.5rem;

@include grid-media-only('xs') {
Expand All @@ -133,7 +133,7 @@
}
}

.global-footer__menu--policy {
.su-global-footer__menu--policy {
font-size: 1.5rem;
font-weight: 300;

Expand All @@ -155,7 +155,7 @@
}
}

.global-footer__copyright {
.su-global-footer__copyright {
font-size: 1.4rem;
font-weight: 300;
text-align: center;
Expand Down
7 changes: 2 additions & 5 deletions core/scss/utilities/mixins/layout/_sticky-footer.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
@charset 'UTF-8';

// This file is here until https://github.com/SU-SWS/decanter/pull/261 gets
// merged and pulled in to this project.

//
// @sticky-footer
//
Expand All @@ -15,12 +12,12 @@
// at the bottom of the page when the content is shorter than the window, but allow
// the content to push the footer below the viewport when the page is long.
//
// $selector - the CSS selector used to target the footer; default '> footer'
// $selector - the CSS selector used to target the footer; default '> .site-footer'
//
// Style guide: Mixins.Layout.Sticky Footer
//

@mixin sticky-footer($selector: '> .global-footer') {
@mixin sticky-footer($selector: '> .site-footer') {
@include padding(0);
@include margin(0);

Expand Down
Loading

0 comments on commit d630c77

Please sign in to comment.