Skip to content

Commit

Permalink
Change sizes of link icons to use px instead of em to prevent occasio…
Browse files Browse the repository at this point in the history
…nal clipping (#523)
  • Loading branch information
yvonnetangsu authored and sherakama committed Oct 25, 2019
1 parent 1bf07cc commit bbe88c2
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 22 deletions.
31 changes: 15 additions & 16 deletions core/dist/css/decanter.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--action.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
// @see scss/utilities/mixins/link/_action-link.scss
//
.su-link--action {
@include link-icon(caret-right, 0.5em);
@include link-icon(caret-right, 10px, right, 0.06em);
}
2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--download.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
// @see scss/utilities/mixins/link/_link-icon.scss
//
.su-link--download {
@include link-icon(download, 0.75em, down);
@include link-icon(download, 12px, down);
}
2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--external.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
// @see scss/utilities/mixins/link/_link-icon.scss
//
.su-link--external {
@include link-icon(arrow-up-right, 0.6em, topright, -0.06em);
@include link-icon(arrow-up-right, 10px, topright);
}
2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--internal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// @see scss/utilities/mixins/link/_link-icon.scss
//
.su-link--internal {
@include link-icon(lock, 0.75em, none, -0.06em);
@include link-icon(lock, 13px, none, -0.03em);

&:hover,
&:focus {
Expand Down
2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--jump.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
// @see scss/utilities/mixins/link/_link-icon.scss
//
.su-link--jump {
@include link-icon(caret-down, 0.65em, down, -0.04em);
@include link-icon(caret-down, 12px, down);
}
2 changes: 1 addition & 1 deletion core/src/scss/components/link/_link--video.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
// @see scss/utilities/mixins/link/_link-icon.scss
//
.su-link--video {
@include link-icon(video, 0.8em, right, -0.2em);
@include link-icon(video, 13px, right, -0.14em);
}

0 comments on commit bbe88c2

Please sign in to comment.