Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

feat: Scaling component metadata change to optional #195

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat: Scaling component metadata change to optional #195

merged 1 commit into from
Nov 3, 2023

Conversation

Ari-suhyeon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DevOps process (non-breaking change which improves efficiency and reliability for CI/CD)
  • Documentation only

What this PR does / why we need it:

Scaling component - metadata change to optional
ex) kubernetes-patch doesn't need metadata

Which issue/s this PR fixes

fixes #193

How Has This Been Tested?

  • moon run tested - check the scaling component works

Checklist:

@Ari-suhyeon Ari-suhyeon added this to the v0.0.15 milestone Nov 3, 2023
@Ari-suhyeon Ari-suhyeon requested a review from pueding November 3, 2023 08:47
@Ari-suhyeon Ari-suhyeon self-assigned this Nov 3, 2023
@Ari-suhyeon Ari-suhyeon linked an issue Nov 3, 2023 that may be closed by this pull request
Scaling component - metadata change to optional #193
Closed
@pueding pueding merged commit 92130b0 into main Nov 3, 2023
1 check passed
@pueding pueding deleted the 193-scaling-component-metadata-change-to-optional branch November 3, 2023 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pueding pueding pueding approved these changes

Assignees

@Ari-suhyeon Ari-suhyeon

Labels
target: scaling-component target:
Projects
None yet
Milestone
v0.0.15
Development

Successfully merging this pull request may close these issues.

Scaling component - metadata change to optional
2 participants
@Ari-suhyeon @pueding