This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
change: telegraf reqired tags added at internal code #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd telegraph metric definitions into toml strings
pueding
suggested changes
Oct 20, 2023
| @@ -395,7 +397,64 @@ impl MetricCollectorManager { | |||
| }; | |||
|
|
|||
| let mut outputs_toml = toml::value::Array::new(); | |||
| let mut inputs_map = HashMap::<String, Vec<serde_json::Map<std::string::String, serde_json::Value>>>::new(); | |||
| if metric_definition.collector == "telegraf" { | |||
There was a problem hiding this comment.
duplicated code
metric_definition.collector == "telegraf"|
|
||
| let mut outputs_toml = toml::value::Array::new(); | ||
| let mut inputs_map = HashMap::<String, Vec<serde_json::Map<std::string::String, serde_json::Value>>>::new(); | ||
| if metric_definition.collector == "telegraf" { |
| error!("[telegraf] inputs not found"); | ||
| continue; | ||
| }; | ||
| let Some(inputs_object) = inputs.as_object() else { |
There was a problem hiding this comment.
let Some(inputs_object) = metric_definition.metadata.get("inputs").and_then(|inputs| inputs.as_object()) else {
error!("[telegraf] Failed to convert metadata.inputs to as_object");
continue;
};| continue; | ||
| }; | ||
|
|
||
| let mut inputs_object_arr = Vec::<serde_json::Map<std::string::String, serde_json::Value>>::new(); |
There was a problem hiding this comment.
add a comment to describe the data structure
//
// Example:
// { // inputs_object
// cloudwatch: [ // inputs_object_arr
// {
// cloudwatch
// },
// {
// cloudwatch
// }
// ]
// }
//
//
…nto 180-telegraf-delete-required-tags-and-handle-internal
pueding
approved these changes
Oct 20, 2023
| let mut root_toml = "".to_string(); | ||
| // Create a TOML array representing the metric definitions | ||
| for metric_definition in metric_definitions { | ||
| if !validation_vector_definition(metric_definition) { |
There was a problem hiding this comment.
It would be good that function names start with a verb
validation_vector_definition => validate_vector_definition
pueding
deleted the
180-telegraf-delete-required-tags-and-handle-internal
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What this PR does / why we need it:
Delete required tags from metric definition and handle them internally.
Which issue/s this PR fixes
fixes #180
How Has This Been Tested?
Checklist: