This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
feat: scaling component google cloud run service #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle cloud functions instance helper
…nto 127-scaling-component-google-cloud-run
bryan-stclab
added
target: scaling-component
Closed
bryan-stclab
changed the title
…ogle cloud functions
pueding
suggested changes
Aug 13, 2023
| .and_then(serde_json::Value::as_str) | ||
| .map(|s| s as &str), | ||
| ) { | ||
| fn extract_container_image_based_on_api_version_1( |
There was a problem hiding this comment.
왜 이 함수가 필요한지 코멘트로 적어주시면 좋을것 같습니다.
아래 inner function들도 마찬가지로
There was a problem hiding this comment.
네, 각 함수에 대하여 주석을 추가하도록 하겠습니다.
pueding
approved these changes
Aug 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What this PR does / why we need it:
The Google Cloud Run Scaling Component has been added to enable scaling of Google Cloud Run services.
Which issue/s this PR fixes
#127
How Has This Been Tested?
I wrote a plan YAML file and conducted tests in my actual Google Cloud Platform environment. (Google Cloud Run Service)
Only Google Cloud Run API tests and unit tests have been written, and the unit test code consists of test forms only.
We plan to enhance and add more unit tests in the future.
Checklist: