Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1231 upgrade prettier v3 #1240

Merged
merged 2 commits into from
Aug 15, 2023
Merged

1231 upgrade prettier v3 #1240

merged 2 commits into from
Aug 15, 2023

Conversation

johnxu16
Copy link
Contributor

  • Upgrade prettier with eslint-plugin-prettier
  • Fix format

Fixes #1231

Affected routes:

  • NULL

Add done video, screenshots

image
Figure: Execute 'yarn lint'

@johnxu16 johnxu16 requested a review from bradystroud August 15, 2023 08:26
@johnxu16 johnxu16 self-assigned this Aug 15, 2023
@johnxu16 johnxu16 marked this pull request as ready for review August 15, 2023 08:36
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1240.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1240.azurewebsites.net

@johnxu16 johnxu16 requested a review from KristenHu August 15, 2023 08:53
Copy link
Contributor

@KristenHu KristenHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@KristenHu KristenHu merged commit d9154f4 into main Aug 15, 2023
@KristenHu KristenHu deleted the 1231_upgrade-prettier-v3 branch August 15, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📦 Upgrade Prettier to v3
2 participants